[PATCH v4 02/10] ARM: DaVinci: base address and lpsc assignments for dm6467

[Rajashekhara, Sudhakar]

Sergei,

Your comment is valid but I feel keeping all hardware related stuffs like base address, LPSC numbers and IRQ numbers in one file say hardware.h is appropriate. I am planning to do this as part of my next set of updated patches. There I'll combine the DM644x hardware.h, psc.h and irq.h. File hardware_dm6467.h will have base address, LPSC assignments and IRQ assignments for DM6467.

Also, I got an offline comment saying I have used DM646x and DM6467 interchangeably. I'll change this and use DM6467 consistently all across the files.

Regards, Sudhakar

-----Original Message-----
From: Sergei Shtylyov [mailto:sshtylyov at ru.mvista.com] 
Sent: Wednesday, September 10, 2008 4:01 PM
To: Rajashekhara, Sudhakar
Cc: davinci-linux-open-source at linux.davincidsp.com
Subject: Re: [PATCH v4 02/10] ARM: DaVinci: base address and lpsc assignments for dm6467

Hello.

Sudhakar Rajashekhara wrote:

> Defines base addresses and LPSC assignments for dm6467.
>
> Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj at ti.com>
>   
[...]
> diff --git a/arch/arm/mach-davinci/include/mach/hardware_dm6467.h b/arch/arm/mach-davinci/include/mach/hardware_dm6467.h
> new file mode 100644
> index 0000000..5b27d3a
> --- /dev/null
> +++ b/arch/arm/mach-davinci/include/mach/hardware_dm6467.h
> @@ -0,0 +1,90 @@
>   
[...]
> +/*
> + * LPSC Assignments
> + */
> +#define DAVINCI_DM646X_LPSC_RESERVED       0
> +#define DAVINCI_DM646X_LPSC_C64X_CPU       1
> +#define DAVINCI_DM646X_LPSC_HDVICP0        2
> +#define DAVINCI_DM646X_LPSC_HDVICP1        3
> +#define DAVINCI_DM646X_LPSC_TPCC           4
> +#define DAVINCI_DM646X_LPSC_TPTC0          5
> +#define DAVINCI_DM646X_LPSC_TPTC1          6
> +#define DAVINCI_DM646X_LPSC_TPTC2          7
> +#define DAVINCI_DM646X_LPSC_TPTC3          8
> +#define DAVINCI_DM646X_LPSC_PCI            13
> +#define DAVINCI_DM646X_LPSC_EMAC           14
> +#define DAVINCI_DM646X_LPSC_VDCE           15
> +#define DAVINCI_DM646X_LPSC_VPSSMSTR       16
> +#define DAVINCI_DM646X_LPSC_VPSSSLV        17
> +#define DAVINCI_DM646X_LPSC_TSIF0          18
> +#define DAVINCI_DM646X_LPSC_TSIF1          19
> +#define DAVINCI_DM646X_LPSC_DDR_EMIF       20
> +#define DAVINCI_DM646X_LPSC_AEMIF          21
> +#define DAVINCI_DM646X_LPSC_McASP0         22
> +#define DAVINCI_DM646X_LPSC_McASP1         23
> +#define DAVINCI_DM646X_LPSC_CRGEN0         24
> +#define DAVINCI_DM646X_LPSC_CRGEN1         25
> +#define DAVINCI_DM646X_LPSC_UART0          26
> +#define DAVINCI_DM646X_LPSC_UART1          27
> +#define DAVINCI_DM646X_LPSC_UART2          28
> +#define DAVINCI_DM646X_LPSC_PWM0           29
> +#define DAVINCI_DM646X_LPSC_PWM1           30
> +#define DAVINCI_DM646X_LPSC_I2C            31
> +#define DAVINCI_DM646X_LPSC_SPI            32
> +#define DAVINCI_DM646X_LPSC_GPIO           33
> +#define DAVINCI_DM646X_LPSC_TIMER0         34
> +#define DAVINCI_DM646X_LPSC_TIMER1         35
> +#define DAVINCI_DM646X_LPSC_ARM_INTC       45
>   

   Placing DM646x LPSC module numbers in this file is inconsistent with 
DM644x LPSC numbers being in psc.h.

WBR, Sergei