omapfb -- panel initialization inflexibility

Imre Deak imre.deak at nokia.com
Mon Dec 5 06:35:54 CST 2005


Actually there is no requirement on calling panel->enable() before
omapfb_set_update_mode(), which enables the LCD DMA. It's even possible
to enable / disable the panel while having the LCD DMA active.

So lets simply switch the order of the two calls in omapfb_probe and the
suspend / resume functions. Please send a patch.

--Imre

On Fri, 2005-12-02 at 19:42 -0800, ext Brian Swetland wrote:
> I have an lcd panel connected to a omap730 based system that *requires*
> that MCK, HSYNC, and VSYNC are active when it is powered on.  It will
> not initialize correctly otherwise.
> 
> I've modified my omapfb driver so that there is a new OMAP_LCDC_*
> flag (OMAP_LCDC_PANEL_INIT_AFTER_LCDC) that determines if the
> enable hook is called where it is in the existing driver, or if
> it is called after omapfb_set_update_mode() returns.
> 
> Any objections to this workaround?  Any suggestions for a better
> name for the flag?  Is there a better value than 0x200 for the flag?
> 
> Thanks,
> 
> Brian
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source at linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source



More information about the Linux-omap-open-source mailing list